Update xeus-cpp version to 0.8.0 dev #347
Conversation
|
I closed the PR as per the comment on the discord. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -11,8 +11,9 @@ | |||
|
|
|||
| // Project version | |||
| #define XEUS_CPP_VERSION_MAJOR 0 | |||
| #define XEUS_CPP_VERSION_MINOR 7 | |||
| #define XEUS_CPP_VERSION_PATCH 1 | |||
| #define XEUS_CPP_VERSION_MINOR 8 | |||
There was a problem hiding this comment.
warning: macro 'XEUS_CPP_VERSION_MINOR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define XEUS_CPP_VERSION_MINOR 8
^| #define XEUS_CPP_VERSION_MINOR 7 | ||
| #define XEUS_CPP_VERSION_PATCH 1 | ||
| #define XEUS_CPP_VERSION_MINOR 8 | ||
| #define XEUS_CPP_VERSION_PATCH 0 |
There was a problem hiding this comment.
warning: macro 'XEUS_CPP_VERSION_PATCH' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
#define XEUS_CPP_VERSION_PATCH 0
^
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 20 20
Lines 957 957
Branches 89 89
=======================================
Hits 783 783
Misses 174 174 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Set-version-to-0.8.0-dev
branch
from
4a08aa3 to
84baaf1
Compare
|
@SylvainCorlay @anutosh491 @vgvassilev I have reopened this, as I think this needs to go in now. A change just went into xeus-cpp, without the version being updated to a dev version. |
|
I think we already discussed this on discord. This just seems like noise (so while releasing we remove the dev label and then after that 1 commit goes in everytime to address this ? that doesn't sound productive to me) Why don't we take a call on what we're releasing when we're releasing ? |
|
I am not sure what noise you are talking about but I'd like to get that in. |
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
This PR updated xeus-cpp version to 0.8.0 dev
Type of change
Please tick all options which are relevant.