Skip to content

Update xeus-cpp to 0.7.1 for release #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@mcbarton mcbarton requested a review from anutosh491 June 10, 2025 14:18
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#define XEUS_CPP_VERSION_MINOR 8
#define XEUS_CPP_VERSION_PATCH 0
#define XEUS_CPP_VERSION_LABEL dev
#define XEUS_CPP_VERSION_MINOR 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'XEUS_CPP_VERSION_MINOR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define XEUS_CPP_VERSION_MINOR 7
        ^

#define XEUS_CPP_VERSION_PATCH 0
#define XEUS_CPP_VERSION_LABEL dev
#define XEUS_CPP_VERSION_MINOR 7
#define XEUS_CPP_VERSION_PATCH 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'XEUS_CPP_VERSION_PATCH' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define XEUS_CPP_VERSION_PATCH 1
        ^

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (66f6182) to head (c92d3e0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491
Copy link
Collaborator

Hey @mcbarton thanks for this .

I am trying to fix this #342 (we had it working for llvm 20.1.5 but not for 20.1.6) so just trying to figure out what is going wrong (i have some intuition as to what is)

Shall fix this and make the release today !

@mcbarton mcbarton mentioned this pull request Jun 11, 2025
4 tasks
@mcbarton mcbarton force-pushed the Set-version-to-0.7.1-for-release branch from a40b0c5 to c92d3e0 Compare June 11, 2025 11:14
@SylvainCorlay
Copy link
Collaborator

Closing as #346 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants