-
Notifications
You must be signed in to change notification settings - Fork 4
opentelemetry: fix import ordering #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM, давай ещё исправим CI? |
0f12183
to
ca0c60c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
0837272
to
a44e88b
Compare
- auto_instrumentation patched away
- Results checked in the test were missing one is_ready() call
- resources module uses constants that are just aliases to ResourceAttributes module. The module has a @deprecated message though. But it doesn't appear to matter at the moment.
- resources certainly have Resource!
@vrslev fixed all issues, also fixed one test that you've added, please take a look, thanks! |
All good, do we need to test the actual auto instrumentation? or is it too hard? |
I think it's pointless due to these reasons:
|
Just an import ordering fix
Also one ignore for mypy due to untyped auto_instrumentation (ugh!)