Skip to content

Allow typing.Final for assignment to name with the same name as funciton #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Allow typing.Final for assignment to name with the same name as funciton #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auto_typing_final/finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def find_definitions_in_scope_grouped_by_name(root: SgNode) -> dict[str, list[Sg
definition_map[identifier].append(node)

for node in root.find_all(rule):
if node_is_in_inner_function_or_class(root, node):
if node_is_in_inner_function_or_class(root, node) or node == root:
continue
for identifier in find_identifiers_in_function_body(node):
definition_map[identifier].append(node)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,10 +585,10 @@ def baz():

("""
def foo():
foo: typing.Final = 1
foo = 1
""", """
def foo():
foo = 1
foo: typing.Final = 1
"""),

("""
Expand Down