Remove (not ignore) typing.Final inside loops

auto_typing_final/main.py

@@ -54,11 +54,15 @@ def is_in_loop(node: SgNode) -> bool:
 
 def make_operation_from_assignments_to_one_name(nodes: list[SgNode]) -> Operation:
     value_assignments: list[Definition] = []
+    has_node_in_loop = False
 
     for node in nodes:
         children = node.children()
 
-        if node.kind() == "assignment" and not is_in_loop(node):
+        if is_in_loop(node):
+            has_node_in_loop = True
+
+        if node.kind() == "assignment":
             match tuple(child.kind() for child in children):
                 case ("identifier", "=", _):
                     value_assignments.append(
@@ -74,6 +78,10 @@ def make_operation_from_assignments_to_one_name(nodes: list[SgNode]) -> Operatio
                     value_assignments.append(OtherDefinition(node))
         else:
             value_assignments.append(OtherDefinition(node))
+
+    if has_node_in_loop:
+        return RemoveFinal(value_assignments)
+
     match value_assignments:
         case [assignment]:
             return AddFinal(assignment)

tests/test_main.py

@@ -299,14 +299,52 @@ def foo():
         a = 1
 """),
 
+("""
+def foo():
+    while True:
+        a: typing.Final = 1
+""", """
+def foo():
+    while True:
+        a = 1
+"""),
+
 ("""
 def foo():
     for _ in ...:
         a: typing.Final = 1
 """, """
 def foo():
+    for _ in ...:
+        a = 1
+"""),
+
+("""
+def foo():
+    for _ in ...:
+        def foo():
+            a: typing.Final = 1
+""", """
+def foo():
+    for _ in ...:
+        def foo():
+            a = 1
+"""),
+
+("""
+def foo():
+    a: typing.Final = 1
+    b: typing.Final = 2
+
     for _ in ...:
         a: typing.Final = 1
+""", """
+def foo():
+    a = 1
+    b: typing.Final = 2
+
+    for _ in ...:
+        a = 1
 """),
 
 ("""