Skip to content

Fix passing of non-ASCII characters as command-line arguments #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix passing of non-ASCII characters as command-line arguments #127

wants to merge 3 commits into from

Conversation

lassoan
Copy link
Member

@lassoan lassoan commented Jul 29, 2022

@lassoan lassoan requested a review from jcfr July 29, 2022 22:32
@jcfr
Copy link
Member

jcfr commented Jul 30, 2022

Overall looks great 👍

It the use of QLatin1String instead of QString::fromLatin1 for stylistic reason ?

@lassoan
Copy link
Member Author

lassoan commented Jul 30, 2022

It the use of QLatin1String instead of QString::fromLatin1 for stylistic reason ?

Yes, I just chose QLatin1String because it indicates that it is simply a constant definition and it is not a conversion.

I could not test it (just the compilation), so it would be great if you could test it on Linux as described here.

@jcfr
Copy link
Member

jcfr commented Jul 31, 2022

Thanks for the detailed explanation. I will test tomorrow and then move forward with creating a new release.

@achataigner
Copy link

Would it be possible to merge this branch ?
It would simplify my work which uses slicer python interpreter: https://discourse.slicer.org/t/python-interpreter-arguments-containing-special-characters/33466

@achataigner
Copy link

achataigner commented Jan 10, 2024 •
edited
Loading

Any feedback ? @jcfr

@lassoan
Copy link
Member Author

lassoan commented Apr 7, 2024

This is still a problem - https://discourse.slicer.org/t/patientname-and-rus-language-trouble/28870/9

@jcfr jcfr force-pushed the fix-utf8-args branch from 872e8df to 1aa735b Compare July 2, 2024 14:04
@jcfr
Copy link
Member

jcfr commented Jul 2, 2024 •
edited
Loading

Once continuous integration is fixed, the branch associated with this pull request will be rebased.

Related pull requests:

@jcfr jcfr force-pushed the fix-utf8-args branch from 1aa735b to 9998a7d Compare July 2, 2024 22:21
@lassoan lassoan mentioned this pull request Feb 25, 2025
Open
@lassoan
Copy link
Member Author

lassoan commented Mar 7, 2025

I've added a fix that also fixes passing special characters in command-line arguments and fixes the issue of not being able to launch Slicer in a path that contains special character (Slicer/Slicer#8229).

@lassoan
BUG: Fix launching with CTKAPPLAUNCHER_WITHOUT_CONSOLE_IO_SUPPORT on …
38dc94a 
…Windows

Application path and command-line arguments can now contain special characters.

Note: console launcher on Windows still has not been fixed. wmain would need to be used instead of main and wide characters should be converted to utf8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfr jcfr Awaiting requested review from jcfr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lassoan @jcfr @achataigner