Skip to content

Generate test files/dirs in app tests #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

dylanhitt
Copy link
Member

@dylanhitt dylanhitt commented Oct 23, 2020

Fixes #149

Checklist

  • Added unit / integration tests for windows, macOS and Linux?
  • Added a changelog entry in CHANGELOG.md?
  • Updated the documentation (README.md, docs)?
  • Does your change work on Linux, Windows and macOS?

@dylanhitt dylanhitt changed the title generate test files/dirs in app test generate test files/dirs in app tests Oct 23, 2020
@dylanhitt dylanhitt marked this pull request as ready for review October 23, 2020 21:28
@dylanhitt dylanhitt changed the title generate test files/dirs in app tests Generate test files/dirs in app tests Oct 24, 2020
@codeclimate
Copy link

codeclimate bot commented Oct 24, 2020

Code Climate has analyzed commit 98ce952 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.3% (-0.1% change).

View more on Code Climate.

@SimonBaeumer
Copy link
Member

Hey @dylanhitt,
I am not sure if you read my comment in the other pull request.
You should make use of testdata inside the same directory, see my comment: #147 (comment)
Than it is not necessary to create a temp directory / file.

Have a nice weekend! :)

@dylanhitt
Copy link
Member Author

Oh, I was unsure. I was following the pattern I saw in test_command_linux_test.go. Should we just migrate everything to tesdata?

@SimonBaeumer
Copy link
Member

Oh, I was unsure. I was following the pattern I saw in test_command_linux_test.go. Should we just migrate everything to tesdata?

Yes, was not my best idea :D If you would like to you can refactor it too :)

@dylanhitt
Copy link
Member Author

I'm gonna close this and re implement with testData

@dylanhitt dylanhitt closed this Oct 25, 2020
@dylanhitt dylanhitt deleted the fix-app-tests branch November 3, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly mock file and dirs in app tests to not read from the filesystem
2 participants