-
Notifications
You must be signed in to change notification settings - Fork 0
feat: v3 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
curlyfriesplease
wants to merge
29
commits into
master
Choose a base branch
from
ENG-3910-node-22
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: v3 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies are still working on compatibility, despite the fact ESLint8 is now EOL
… errors when used in other repos
…eing unable to find the unicorn.js file
…equires it" This reverts commit e9ddd12.
…ptions for ESLint 3.x
… added to either .eslintrc or .eslintrc.yml
…d in such a way that it confuses this rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3
This version:
8.57.1. While v9 is available, many of our dependencies are not ready for it yet.unicornplugin. Its ruleset is a bit too strict and contravenes a lot of our code, but not in ways that seem especially helpful to remediate.stylisticplugin, as a number of our rules have been deprecated byeslint-typescriptand moved to that plugin instead.ENG-3910
Testing
This has been tested as working on the following repos:
serverless-payments-bootstrapserverless-fundraiser-signupserverless-giftaidserverless-prize-platform