Skip to content

Conversation

@curlyfriesplease
Copy link

@curlyfriesplease curlyfriesplease commented May 20, 2025

Version 3

This version:

  • Moves to the highest available version of ESLint 8, 8.57.1. While v9 is available, many of our dependencies are not ready for it yet.
  • Removes the unicorn plugin. Its ruleset is a bit too strict and contravenes a lot of our code, but not in ways that seem especially helpful to remediate.
  • Adds the stylistic plugin, as a number of our rules have been deprecated by eslint-typescript and moved to that plugin instead.
  • Adds an override to target TS files, see index.js
  • SonarJS v3 is designed to align with ESLint v9's new config format, which uses a different export mechanism for configurations. Because of this, I have changed the SonarJS ruleset from 'recommended' to 'recommended-legacy'. This is specifically designed for ESLint v8 compatibility in eslint-plugin-sonarjs v3.0+ while maintaining the same rule configuration as the original recommended preset.
  • Adds a large number of new tests. The majority have been AI generated and I have kept the ones I liked the look of.

ENG-3910

Testing

This has been tested as working on the following repos:
serverless-payments-bootstrap
serverless-fundraiser-signup
serverless-giftaid
serverless-prize-platform

…endencies are still working on compatibility, despite the fact ESLint8 is now EOL
@curlyfriesplease curlyfriesplease changed the title ENG-3910-node-22 v3 May 23, 2025
@curlyfriesplease curlyfriesplease marked this pull request as ready for review May 23, 2025 12:49
@curlyfriesplease curlyfriesplease requested a review from seb-cr May 23, 2025 13:49
@curlyfriesplease curlyfriesplease changed the title v3 feat: v3 May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant