Skip to content

Fix ./mill init unpack path #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented May 26, 2025

InitModule#init assumes that zip file name is the same as the path to the content inside the zip, which was broken recently in #5147. This PR makes it consistent again by computing the name once and using it both in naming the zip and in naming the enclosing folder of its contents

@lihaoyi lihaoyi merged commit 0d8285e into com-lihaoyi:main May 26, 2025
38 checks passed
@lefou lefou added this to the 1.0.0-RC2 milestone May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants