-
-
Notifications
You must be signed in to change notification settings - Fork 2
FIrst stab at #212 #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DmitrySharabin
wants to merge
9
commits into
main
Choose a base branch
from
issue-212
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FIrst stab at #212 #213
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5ea9dd5
[color-swatch] Handle complex color values gracefully
DmitrySharabin 48dd2e7
Address feedback: Move the code to a util function
DmitrySharabin f6f88bc
Address feedback: Move to a static method
DmitrySharabin 92f46d0
Address feedback: Improve API + add some docs
DmitrySharabin 5df5d93
Address feedback
DmitrySharabin 580bd65
Address feedback: Avoid infinite loop
DmitrySharabin cc39297
Prevent bugs
DmitrySharabin fe90abf
Address feedback: Lessen nesting
DmitrySharabin ac62f55
Preserve original background color
DmitrySharabin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should store the element's previous
backgroundColorso we can restore it, rather than overwriting.Also, we should avoid the DOM I/O if the element already has that background (since any DOM operation is slow), so perhaps we can pass in an option for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it. Thanks!
Could you elaborate, please? How do you see it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like, a setting (name TBD) that will tell the function "the element I'm giving you already has the right background, don't bother setting it"