[color-chart] First step in <channel-picker> integration
#170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for color-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LeaVerou
reviewed
Nov 25, 2024
LeaVerou
reviewed
Nov 27, 2024
LeaVerou
reviewed
Nov 27, 2024
LeaVerou
reviewed
Nov 27, 2024
DmitrySharabin
force-pushed
the
chart-channel-picker-integration
branch
2 times, most recently
from
7f70960 to
f272bf7
Compare
LeaVerou
reviewed
Dec 4, 2024
src/color-chart/color-chart.js
Outdated
| try { | ||
| return Self.Color.Space.resolveCoord(this.y, "oklch"); | ||
| } | ||
| catch { |
There was a problem hiding this comment.
Why do we have this new error condition? I don't understand why this is here based on the comment below.
There was a problem hiding this comment.
Thank you for this question! You are absolutely right: We shouldn't handle invalid values of y here. I moved the logic to another place. Could you please take a look and see if it's more correct now?
DmitrySharabin
force-pushed
the
chart-channel-picker-integration
branch
2 times, most recently
from
c745313 to
eeded87
Compare
DmitrySharabin
force-pushed
the
chart-channel-picker-integration
branch
from
eeded87 to
e93fa18
Compare
DmitrySharabin
added a commit
that referenced
this pull request
Dec 9, 2024
`<channel-picker>` is already integrated into charts (see #170)
DmitrySharabin
added a commit
that referenced
this pull request
Dec 9, 2024
`<channel-picker>` is already integrated into charts (see #170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to tweak styles here depending on what base style of
<channel-picker>we choose (we might end up with this: #169). So, it's only the first step. The implemented logic will be the same regardless.Live preview: https://deploy-preview-170--color-elements.netlify.app/src/color-chart/