Skip to content

Conversation

@coletrammer
Copy link
Owner

Summary

Closes #18. This is really cool, because now the layout save/restore feature also remembers the pane's current working directory. And splitting new panes or creating new tabs will use the current active pane's current working directory. This is a massive usability improvement.

Because we are using OSC 7, this relies on shell integration. In my configuration, I'm relying on the outer terminal's shell integration.

Check List

  • Self-review the code
  • Update tests if necessary
  • Update docs if necessary

The next commit will actually make use of this escape.
This also updates the terminal tests for cases which were
using OSC 7 but that was previously ignored.
@coletrammer coletrammer added this to the 0.1 milestone Apr 24, 2025
@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 68.18182% with 35 lines in your changes missing coverage. Please review.

Project coverage is 66.13%. Comparing base (82483f2) to head (7d27c03).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/pane.cpp 29.72% 26 Missing ⚠️
src/actions.cpp 0.00% 6 Missing ⚠️
lib/src/layout.cpp 90.00% 1 Missing ⚠️
lib/src/terminal.cpp 92.30% 1 Missing ⚠️
src/tab.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   65.92%   66.13%   +0.20%     
==========================================
  Files          66       68       +2     
  Lines        5289     5368      +79     
  Branches      750      763      +13     
==========================================
+ Hits         3487     3550      +63     
- Misses       1802     1818      +16     
Flag Coverage Δ
Linux 66.13% <68.18%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coletrammer coletrammer merged commit 7d27c03 into main Apr 24, 2025
8 checks passed
@coletrammer coletrammer deleted the cwd branch April 24, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

terminal: Support current working directory report (OSC 7)

1 participant