Skip to content

fix: Mobile WalletLink should redirect instantly #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
+11 −10
Merged

fix: Mobile WalletLink should redirect instantly #1688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions packages/wallet-sdk/src/sign/walletlink/relay/ui/WLMobileRelayUI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { CBW_MOBILE_DEEPLINK_URL } from ':core/constants.js';
import { RelayUI } from './RelayUI.js';
import { RedirectDialog } from './components/RedirectDialog/RedirectDialog.js';
import { getLocation } from './components/util.js';
import { RelayUI } from './RelayUI.js';
import { CBW_MOBILE_DEEPLINK_URL } from ':core/constants.js';

export class WLMobileRelayUI implements RelayUI {
private readonly redirectDialog: RedirectDialog;
Expand Down Expand Up @@ -35,16 +35,17 @@ export class WLMobileRelayUI implements RelayUI {
}

openCoinbaseWalletDeeplink(walletLinkUrl?: string): void {
this.redirectDialog.present({
title: 'Redirecting to Coinbase Wallet...',
buttonText: 'Open',
onButtonClick: () => {
this.redirectToCoinbaseWallet(walletLinkUrl);
},
});
// redirect to coinbase wallet immediately to avoid Safari/Chrome popup(deeplink) blocking
this.redirectToCoinbaseWallet(walletLinkUrl);

setTimeout(() => {
this.redirectToCoinbaseWallet(walletLinkUrl);
this.redirectDialog.present({
title: 'Redirecting to Coinbase Wallet...',
buttonText: 'Open',
onButtonClick: () => {
this.redirectToCoinbaseWallet(walletLinkUrl);
},
});
}, 99);
}

Expand Down