Skip to content

Conversation

@spencerstock
Copy link
Contributor

@spencerstock spencerstock commented Jul 11, 2025

ENG-0003: Code Reviews Guidelines

What changed? Why?

Reordered deeplink navigation to execute before publishing web3 request events on mobile web. This change addresses Safari's popup blocking behavior by ensuring the deeplink opens within the user interaction context.

The key change:

  • Moved openCoinbaseWalletDeeplink call to execute immediately when a web3 request is initiated on mobile web
  • The event publishing now happens asynchronously after the deeplink navigation

How was this tested?

Manual testing on mobile Safari to verify deeplinks open without being blocked by the popup blocker.

How can reviewers manually test these changes?

  1. Open the test app on mobile Safari
  2. Connect wallet and trigger any web3 request (e.g., sign message, send transaction)
  3. Verify the Coinbase Wallet deeplink opens immediately without Safari's popup warning
  4. Confirm the web3 request is still processed correctly after navigation

Demo/screenshots

automerge=false

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 11, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@spencerstock spencerstock changed the title [IM-20267] Prioritize deeplink navigation before event publishing Prioritize deeplink navigation before event publishing Jul 11, 2025
@spencerstock spencerstock marked this pull request as ready for review July 11, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants