Skip to content

Conversation

@montycheese
Copy link
Contributor

…accounts array

Summary

GrantSpendPermission was being called with the sub account address as the account param, which was resulting in the sub account granting the spend permission. This was a side effect of the re-ordering change #1681

How did you test your changes?

verified in playground

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 8, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@montycheese montycheese merged commit 953fbbc into master Jul 8, 2025
8 checks passed
@montycheese montycheese deleted the indexfix branch July 8, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants