Skip to content

Conversation

@stephancill
Copy link
Contributor

Summary

Linear:

  • Routes all eth_requestAccounts requests through wallet_connect and cache sub account results.
  • Refactor addSubAccount function into existing handleResponse

How did you test your changes?

Unit tests

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 3, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@stephancill stephancill requested a review from montycheese July 3, 2025 13:26
@stephancill stephancill requested a review from fan-zhang-sv July 3, 2025 13:33
@stephancill stephancill merged commit 4539500 into master Jul 3, 2025
8 checks passed
@stephancill stephancill deleted the stephancilliers/ba-2309-sdk-cache-sub-account-info-during-rpc-calls branch July 3, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants