Skip to content

Conversation

@montycheese
Copy link
Contributor

@montycheese montycheese commented Jun 24, 2025

…vailable

Summary

  1. Do not provide custom error handling on insufficient balance errors for sub account if error data is not available. This is the case if wallet_sendCalls is invoked without the funding capability.
  2. renamed spend limits -> spend permissions in a place that was missed during the renaming refactor

How did you test your changes?

unit test coverage

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jun 24, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@montycheese montycheese merged commit 15b5a8e into master Jun 24, 2025
8 checks passed
@montycheese montycheese deleted the funding-error branch June 24, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants