websocket refactor for improved connection reliability #1664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
spencerstock
force-pushed
the
spencer/websocket-refactor
branch
5 times, most recently
from
70f5fe1 to
186d887
Compare
spencerstock
force-pushed
the
spencer/websocket-refactor
branch
from
186d887 to
646466a
Compare
| throw new Error('webSocket object is not null'); | ||
| } | ||
| if (this.isDisconnecting) { | ||
| throw new Error('WebSocket is disconnecting, cannot reconnect on same instance'); |
Contributor
There was a problem hiding this comment.
nit: reconnect => connect for consistency with the function name we're in
fan-zhang-sv
approved these changes
Jun 18, 2025
Contributor
fan-zhang-sv
left a comment
fan-zhang-sv
left a comment
There was a problem hiding this comment.
LGTM!
Tested locally against both spencer's hosted commerce site + locally hosted playground
- desktop to mobile
- mobile to mobile
tested delaying approval for 10+ second, all test cases went thru, so lit
fan-zhang-sv
approved these changes
Jun 18, 2025
cb-jake
reviewed
Jun 23, 2025
| const address = await this.cipher.decrypt(encryptedEthereumAddress); | ||
| this.listener?.accountUpdated(address); | ||
| } catch { | ||
| // Had error decrypting |
Contributor
There was a problem hiding this comment.
Should we output these errors anywhere? Failing silently is a bit concerning
vishnumad
approved these changes
Jun 23, 2025
cb-jake
approved these changes
Jun 23, 2025
fan-zhang-sv
pushed a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This set of fixes specifically targets reliability on mobile-mobile flows. It speeds up and fixes things in the reconnect process for our walletlink websockets.
Connection Management:
Heartbeat:
Browser Event Handling:
How did you test your changes?
manually
Also tested for regressions on long-idle desktop chrome tabs (Will's service worker fix):
Also built locally and tested the playground, extension, desktop to mobile
Failure 1 (before fixes)
commercefail1.mp4
Failure 2 (before fixes)
commercefail2.mp4
Success with fixes
commercesuccess1.mp4