Skip to content

Conversation

@stephancill
Copy link
Contributor

Summary

Fixes a bug where the sub account was signing its own spend permission in the playground

How did you test your changes?

Manual testing

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jun 17, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@cb-jake cb-jake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I fixed locally but forgot to push

@cb-jake cb-jake merged commit db766f9 into master Jun 17, 2025
8 checks passed
@cb-jake cb-jake deleted the fix/add-subaccount-grant-spend-permission branch June 17, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants