Skip to content

Conversation

@wcrozier12
Copy link
Contributor

@wcrozier12 wcrozier12 commented Jun 16, 2025

Summary

  • Adds wallet_sign ephemeral request support
  • Updates SCWSigner to forward requests to the popup

How did you test your changes?

Tested with local patched SDK version

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jun 16, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wcrozier12 wcrozier12 force-pushed the codycrozier/ba-2160-sdk-support-wallet_sign-ephemeral-method branch from bc0d3a2 to c4f1d7b Compare June 16, 2025 23:12
@fan-zhang-sv fan-zhang-sv merged commit 43faf9f into coinbase:master Jun 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants