Update ERC-7895 support for wallet_addSubAccount #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
cb-jake
commented
Mar 14, 2025
|
|
||
| // Wait for the popup to be loaded before sending the request | ||
| await this.communicator.waitForPopupLoaded?.(); | ||
| const address = get(request, 'params[0].address') as string; |
Contributor
Author
There was a problem hiding this comment.
Main change for import support
cb-jake
commented
Mar 14, 2025
montycheese
reviewed
Mar 18, 2025
examples/testapp/src/pages/import-sub-account/components/DeploySubAccount.tsx
Show resolved
Hide resolved
fan-zhang-sv
approved these changes
Mar 20, 2025
Collaborator
|
Review Error for fan-zhang-sv @ 2025-03-20 22:08:39 UTC |
fan-zhang-sv
previously approved these changes
Mar 20, 2025
fan-zhang-sv
approved these changes
Mar 24, 2025
montycheese
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new demo screen to test import flow for importing existing deployed sub accounts
How did you test your changes?
Manually
import-retail-ejection-flow.mov