feat: prepare wallet rpcs #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
stephancill
force-pushed
the
feat/prepare-wallet-rpcs
branch
2 times, most recently
from
b0ad388 to
a7434bf
Compare
montycheese
reviewed
Mar 19, 2025
Contributor
montycheese
left a comment
montycheese
left a comment
There was a problem hiding this comment.
Looks good so far, a few comments and questions
packages/wallet-sdk/src/sign/scw/utils/createSubAccountSigner.ts
Outdated
Show resolved
Hide resolved
packages/wallet-sdk/src/sign/scw/utils/createSubAccountSigner.ts
Outdated
Show resolved
Hide resolved
packages/wallet-sdk/src/sign/scw/utils/createSubAccountSigner.ts
Outdated
Show resolved
Hide resolved
packages/wallet-sdk/src/sign/scw/utils/createSubAccountSigner.ts
Outdated
Show resolved
Hide resolved
stephancill
force-pushed
the
feat/prepare-wallet-rpcs
branch
from
dd1f73d to
9dd89da
Compare
montycheese
previously approved these changes
Mar 21, 2025
|
Martybb166 |
cb-jake
reviewed
Mar 24, 2025
cb-jake
reviewed
Mar 24, 2025
cb-jake
reviewed
Mar 24, 2025
cb-jake
reviewed
Mar 24, 2025
packages/wallet-sdk/src/sign/scw/utils/createSubAccountSigner.ts
Outdated
Show resolved
Hide resolved
cb-jake
reviewed
Mar 24, 2025
cb-jake
reviewed
Mar 24, 2025
Contributor
cb-jake
left a comment
cb-jake
left a comment
There was a problem hiding this comment.
Looks good. Only thing that has to change is removing Buffer. The only reason this is working locally is the test app is next which polyfills Buffer into the browser env
stephancill
force-pushed
the
feat/prepare-wallet-rpcs
branch
from
1d4e210 to
ac53c2f
Compare
cb-jake
reviewed
Mar 25, 2025
cb-jake
reviewed
Mar 25, 2025
packages/wallet-sdk/src/sign/scw/utils/createSubAccountSigner.ts
Outdated
Show resolved
Hide resolved
cb-jake
reviewed
Mar 25, 2025
cb-jake
reviewed
Mar 26, 2025
cb-jake
approved these changes
Mar 26, 2025
montycheese
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace wallet_sendCalls with wallet_prepareCalls + wallet_sendPreparedCalls
How did you test your changes?
Tried Send Calls on playground and updated tests