-
-
Notifications
You must be signed in to change notification settings - Fork 26
Add StartWorkflowMixin #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there 👋,
Thanks for reaching out and your contribution. I left you a review to help you improve your patch. Next time, maybe consider opening a discussion before jumping right into code, to keep review cycles shorter.
Best
Joe
This allows to start new workflows from views that don't inherit from BaseCreateView. This is useful if you e.g. want to start a view from json input and don't need forms.
b3336ed
to
a6f456d
Compare
7f8855a
to
d047d86
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 97.87% 97.88%
=======================================
Files 17 17
Lines 705 708 +3
=======================================
+ Hits 690 693 +3
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty and wrapped this up for you 😃
@@ -19,6 +19,7 @@ | |||
from .conf import settings | |||
from .typing import HUMAN, MACHINE | |||
from .utils import NoDashDiGraph | |||
from .views import StartViewMixin |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
This allows to start new workflows from views that don't inherit from BaseCreateView. This is useful if you e.g. want to start a view from json input and don't need forms.