Skip to content

Add StartWorkflowMixin #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Conversation

fvollmer
Copy link
Contributor

@fvollmer fvollmer commented Apr 9, 2025

This allows to start new workflows from views that don't inherit from BaseCreateView. This is useful if you e.g. want to start a view from json input and don't need forms.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there 👋,

Thanks for reaching out and your contribution. I left you a review to help you improve your patch. Next time, maybe consider opening a discussion before jumping right into code, to keep review cycles shorter.

Best
Joe

@codingjoe codingjoe self-requested a review May 4, 2025 14:05
codingjoe

This comment was marked as outdated.

@codingjoe codingjoe requested review from codingjoe and removed request for codingjoe May 4, 2025 14:05
This allows to start new workflows from views that don't inherit from BaseCreateView. This is useful if you e.g. want to start a view from json input and don't need forms.
@fvollmer fvollmer force-pushed the StartWorkflowMixin branch from b3336ed to a6f456d Compare May 5, 2025 07:01
@codingjoe codingjoe force-pushed the StartWorkflowMixin branch from 7f8855a to d047d86 Compare May 5, 2025 20:03
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (c45f138) to head (4ed389e).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   97.87%   97.88%           
=======================================
  Files          17       17           
  Lines         705      708    +3     
=======================================
+ Hits          690      693    +3     
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty and wrapped this up for you 😃

@@ -19,6 +19,7 @@
from .conf import settings
from .typing import HUMAN, MACHINE
from .utils import NoDashDiGraph
from .views import StartViewMixin

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'StartViewMixin' may not be defined if module
joeflow.views
is imported before module
joeflow.models
, as the
definition
of StartViewMixin occurs after the cyclic
import
of joeflow.models.
@codingjoe codingjoe merged commit 534f336 into codingjoe:main May 5, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants