Skip to content

Status L2 Linea test deployment #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

2-towns
Copy link
Contributor

@2-towns 2-towns commented Mar 13, 2025

No description provided.

@emizzle
Copy link
Collaborator

emizzle commented Apr 9, 2025

Hmm, maybe we should commit these files so we can re-deploy on Linea if needed? IOW, maybe we should take this out of draft? Thoughts?

@2-towns 2-towns marked this pull request as ready for review April 9, 2025 06:35
Copy link
Collaborator

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks good. However, is there a particular reason for wanting to commit the zkey and r1cs? These are both very large files (and could get a lot larger).

@2-towns
Copy link
Contributor Author

2-towns commented May 19, 2025

Overall I think this looks good. However, is there a particular reason for wanting to commit the zkey and r1cs? These are both very large files (and could get a lot larger).

There is no specific reason, I wasn't sure the importance to add them into git or not.

@2-towns
Copy link
Contributor Author

2-towns commented May 19, 2025

Overall I think this looks good. However, is there a particular reason for wanting to commit the zkey and r1cs? These are both very large files (and could get a lot larger).

Those files are committed for other networks, like testnet for example.

@emizzle
Copy link
Collaborator

emizzle commented May 19, 2025

Those files are committed for other networks, like testnet for example.

Ah yes, I remember we moved them from nim-codex to codex-contracts-eth. But after the circuit downloader was put in, do we need to keep these files in codex-contracts-eth? @dryajov ?

@veaceslavdoina
Copy link
Contributor

veaceslavdoina commented May 23, 2025

Those files are committed for other networks, like testnet for example.

Ah yes, I remember we moved them from nim-codex to codex-contracts-eth. But after the circuit downloader was put in, do we need to keep these files in codex-contracts-eth? @dryajov ?

@emizzle, I would assume these files (zkey and r1cs) are similar to the existing network (codex_testnet / codex_devnet) from my PR #135.

I was added them following an example for codexdisttestnetwork added by @AuHau in #89, @benbierens in #96 / #178, and @gmega in #121.

@AuHau was first, let's ask him for more details - why do we need zkey and r1cs if we have them already on CDN?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants