Update verification-code entrypoint

[mfrancisc]

Modify the /api/v1/signup/verification/activation-code endpoint so that if usersignup does not exists it creates it.

Jira: https://issues.redhat.com/browse/SANDBOX-1209

e2e tests: codeready-toolchain/toolchain-e2e#1158

[alexeykazakov]

Thanks!

Can we also add e2e tests for this too?

• There is no usersignup
• There is a usersignup pending verification (I guess we already have this test)
• There is a usersingup which is deactivated

[codecov]

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (e236c9a) to head (3e8398f).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/verification/service/verification_service.go	18.18%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   81.11%   81.03%   -0.09%     
==========================================
  Files          44       45       +1     
  Lines        3532     3554      +22     
==========================================
+ Hits         2865     2880      +15     
- Misses        580      587       +7     
  Partials       87       87              

Flag	Coverage Δ
unittests	81.03% <62.50%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mfrancisc]

There is a usersignup pending verification (I guess we already have this test)

@alexeykazakov it looks like the parallel e2e test suite runs without automatic approval and we approve "manually". See: https://github.com/codeready-toolchain/toolchain-e2e/blob/c63fa0f08e841d589abaef3e3268736766a466ea/test/e2e/parallel/registration_service_test.go#L719-L732

Thus unless we move the test elsewhere I'm not sure how we can test this in e2e.

[alexeykazakov]

Thus unless we move the test elsewhere I'm not sure how we can test this in e2e.

Yeah... since the approval strategy is a global configuration we can't turn it on and off just for specific tests (because we run tests in parallel). So let's skip this e2e test case then. It's not an easy task.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mfrancisc]

/retest

[mfrancisc]

/retest

updated e2e

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud