return information that user was banned

[MatousJobanek]

When user is banned, then instead of returning the "pending approval" state, the reg-service should return a forbidden error with information that the account was banned.

paired PR codeready-toolchain/toolchain-e2e#1141

KUBESAW-267

[fbm3307]

Looks good just some minor suggestion on text of the error.

[alexeykazakov]

Looks good. I would rephrase the message a bit though.

[metlos]

Looks good with the messaging changes @alexeykazakov proposed.

[alexeykazakov]

You need to update the e2e-tests too :)

=== RUN   TestUserManagement/TestUserBanning/register_new_user_with_preexisting_ban
    banneduser.go:21: BannedUser 'testuserb915aabc-087f-4bd9-a851-649753f05e9b@test.com' created
    user_management_test.go:653: 
        	Error Trace:	/tmp/toolchain-e2e/test/e2e/user_management_test.go:653
        	            				/go/pkg/mod/github.com/stretchr/testify@v1.10.0/suite/suite.go:115
        	Error:      	Not equal: 
        	            	expected: "forbidden: user has been banned"
        	            	actual  : "forbidden: Access to the Developer Sandbox has been suspended due to suspicious activity or detected abuse."
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-forbidden: user has been banned
        	            	+forbidden: Access to the Developer Sandbox has been suspended due to suspicious activity or detected abuse.
        	Test:       	TestUserManagement/TestUserBanning/register_new_user_with_preexisting_ban

[MatousJobanek]

Yeah, I looked only at the registration-service test file and I didn't find anything relevant there. I missed the user-management one - done in codeready-toolchain/toolchain-e2e#1141

[MatousJobanek]

/retest
OLM failed

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (deee157) to head (ac0a1b7).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files          43       43           
  Lines        3517     3518    +1     
=======================================
+ Hits         2852     2853    +1     
  Misses        578      578           
  Partials       87       87           

Flag	Coverage Δ
unittests	81.09% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, metlos, mfrancisc, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,fbm3307,metlos,mfrancisc,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud