-
Notifications
You must be signed in to change notification settings - Fork 36
Removing unsupported service #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unsupported service #511
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrosental, mfrancisc, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 32 32
Lines 3109 3109
=======================================
Hits 2652 2652
Misses 371 371
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
remove unsupported service:
$ golangci-lint config verify --config=./.golangci.yml jsonschema: "" does not validate with "/additionalProperties": additional properties 'service' not allowed
Similar Prs