drop verification-service option & use DefaultTransport instead #505
Conversation
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
rsoaresd,
fbm3307 and
metlos
as code owners
|
| // default function to return an instance of Verification service | ||
| f.verificationServiceFunc = func(_ ...verificationservice.VerificationServiceOption) service.VerificationService { | ||
| return verificationservice.NewVerificationService(f.getContext(), f.verificationServiceOptions...) | ||
| } | ||
|
|
||
| f.signupServiceFunc = func(_ ...signupservice.SignupServiceOption) service.SignupService { | ||
| return signupservice.NewSignupService(f.getContext().Client(), f.signupServiceOptions...) | ||
| } | ||
|
|
There was a problem hiding this comment.
this was the only place where verificationServiceFunc and signupServiceFunc were used. Also making ready for additional cleanup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
==========================================
- Coverage 85.34% 85.33% -0.01%
==========================================
Files 32 32
Lines 3118 3116 -2
==========================================
- Hits 2661 2659 -2
Misses 371 371
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MatousJobanek
merged commit bdaeecc
into
codeready-toolchain:master
when the
DefaultTransportis used, then there is no need to mock the HTTP Client to make gock working, thus we can simplify the tests and the other related code.KUBESAW-260