Skip to content

Upgrade k8s depencencies in registration-service for Openshift 4.16 #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ranakan19
Copy link
Contributor

Upgrades:

Tool/Library Current Version Updates to Version
Golang 1.20 1.21
k8s.io/* v0.27.0 v0.29.2
controller-runtime v0.15 v0.17.3
controller-gen v0.12.0 v0.14.0

Changes in code wrt to controller-runtime upgrade (introduced in controller-runtime v0.16.0:

wrt: https://issues.redhat.com/browse/SANDBOX-686

@ranakan19 ranakan19 changed the title Openshift 4 16 regserv Upgrade k8s depencencies in registration-service for Openshift 4.16 Jan 20, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (280e4ec) to head (6d607cd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   85.11%   85.11%           
=======================================
  Files          32       32           
  Lines        3118     3118           
=======================================
  Hits         2654     2654           
  Misses        376      376           
  Partials       88       88           
Flag Coverage Δ
unittests 85.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, ranakan19, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,fbm3307,ranakan19,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ranakan19 ranakan19 requested a review from metlos as a code owner January 24, 2025 19:47
Copy link

sonarqubecloud bot commented Feb 3, 2025

@ranakan19 ranakan19 merged commit 31223e0 into codeready-toolchain:master Feb 3, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants