Skip to content

add public-viewer support to SpaceLister's Get #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 26, 2024
Merged

add public-viewer support to SpaceLister's Get #451

merged 23 commits into from
Aug 26, 2024

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Jul 25, 2024 •
edited
Loading

This PR is part of the effort of splitting PR #443

Requires the following PRs to be merged

filariow added 3 commits July 25, 2024 14:10
@filariow
add public-viewer support to pkg/configuration
414cf41 
this commit is part of PR codeready-toolchain#443

Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
add public-viewer support to pkg/context
06efa59 
this commit is part of PR codeready-toolchain#443

Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
add public-viewer support to SpaceLister's Get
99e41e8 
this commit is part of the effort of splitting PR codeready-toolchain#443

Signed-off-by: Francesco Ilario <filario@redhat.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (28556e0) to head (ebb8e55).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/proxy/handlers/spacelister_get.go 91.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   78.62%   78.73%   +0.10%     
==========================================
  Files          42       42              
  Lines        2704     2732      +28     
==========================================
+ Hits         2126     2151      +25     
- Misses        487      489       +2     
- Partials       91       92       +1
Flag Coverage Δ
unittests 78.73% <91.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filariow filariow mentioned this pull request Jul 29, 2024
Merged
7 tasks
@filariow filariow marked this pull request as ready for review July 31, 2024 08:28
alexeykazakov
alexeykazakov reviewed Jul 31, 2024
View reviewed changes
filariow added 6 commits August 1, 2024 11:05
@filariow
simplify logs by using Errorf
5412a91 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
improve logs
d1b21d0 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
fix logs
c34dfad 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
remove unused parameter from getUserSpaceBinding
0af2c8f 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
update comments
2d452c9 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
remove context's PublicViewerEnabled set
9f455b3 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow filariow requested a review from alexeykazakov August 1, 2024 15:13
alexeykazakov
alexeykazakov reviewed Aug 1, 2024
View reviewed changes
filariow added 3 commits August 5, 2024 16:59
@filariow
Merge branch 'master' into pv-532-spacelister-get
9ab1fc2
@filariow
remove expectedErr
af7bb99 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
fix test case title
8736124 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
add missing tests
a525db5 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow filariow requested a review from alexeykazakov August 5, 2024 16:17
alexeykazakov
alexeykazakov approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of minor suggestions.

@openshift-ci openshift-ci bot added the approved label Aug 5, 2024
filariow and others added 2 commits August 5, 2024 19:03
@filariow @alexeykazakov
Update pkg/proxy/handlers/spacelister_get_test.go
7b3c4cd 
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
@filariow @alexeykazakov
Update pkg/proxy/handlers/spacelister_get_test.go
9d94638 
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
mfrancisc
mfrancisc approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 👍

I have only one minor comment!

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

filariow and others added 3 commits August 6, 2024 13:07
@filariow @mfrancisc
Update pkg/proxy/handlers/spacelister_get.go
ab258fd 
Co-authored-by: Francisc Munteanu <fmuntean@redhat.com>
@filariow
improve unit tests
98bd360 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
cleanup unit-tests
6c0bbaf 
Signed-off-by: Francesco Ilario <filario@redhat.com>
mfrancisc
mfrancisc reviewed Aug 13, 2024
View reviewed changes
filariow and others added 2 commits August 13, 2024 11:12
@filariow @mfrancisc
Update pkg/proxy/handlers/spacelister_get_test.go
f0bf289 
Co-authored-by: Francisc Munteanu <fmuntean@redhat.com>
@filariow
rollback unneeded changes
a5541e2 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
Copy link
Contributor Author

/retest

2 similar comments
@filariow
Copy link
Contributor Author

/retest

@filariow
Copy link
Contributor Author

/retest

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
15.3% Duplication on New Code

See analysis details on SonarCloud

@filariow
Copy link
Contributor Author

/retest

as codeready-toolchain/toolchain-e2e#1036 merged

@filariow
Copy link
Contributor Author

/test all

@filariow filariow merged commit c32a2fa into codeready-toolchain:master Aug 26, 2024
10 of 11 checks passed
@filariow filariow deleted the pv-532-spacelister-get branch August 26, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrancisc mfrancisc mfrancisc approved these changes

@alexeykazakov alexeykazakov alexeykazakov approved these changes

@MatousJobanek MatousJobanek Awaiting requested review from MatousJobanek

@xcoulon xcoulon Awaiting requested review from xcoulon

@rajivnathan rajivnathan Awaiting requested review from rajivnathan

@ranakan19 ranakan19 Awaiting requested review from ranakan19

@sbryzak sbryzak Awaiting requested review from sbryzak

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filariow @alexeykazakov @mfrancisc