Calculate and return days remaining in get signup response

[sbryzak]

If the UserSignup.Status.ScheduledDeactivationTimestamp property is set, then use it to calculate the number of days remaining in the user's trial and return that value in the get signup response.

e2e tests: codeready-toolchain/toolchain-e2e#995

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (644e2e8) to head (ab70570).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   78.10%   78.14%   +0.03%     
==========================================
  Files          41       41              
  Lines        2677     2681       +4     
==========================================
+ Hits         2091     2095       +4     
  Misses        491      491              
  Partials       95       95              

Flag	Coverage Δ
unittests	78.14% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MatousJobanek]

I haven't seen any PR for the changes in toolchain-e2e, could you please create one?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
11.6% Duplication on New Code

See analysis details on SonarCloud

[alexeykazakov]

Looks good to me but I would get rid of the DaysRamaining thing and let the UI calculate it from the EndDate if needed.

[sbryzak]

DaysRemaining is now removed.

[MatousJobanek]

I don't see any unit test that would verify the case when the ScheduledDeactivationTimestamp/ProvisionedTime is not set - we need to make sure that the empty string is returned in this case.
Sorry if I missed it somewhere.

[sbryzak]

Added check to existing test to ensure StartDate / EndDate are now blank when user is not active.

[MatousJobanek]

Nice 👍 Thanks for the extra changes 🙏

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, sbryzak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,sbryzak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment