Skip to content

revert go-version-file usage in govulncheck gh action #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rsoaresd
Copy link
Contributor

Description

There is a bug when using go-version-file: golang/go#70036, which leads to pick go 1.24 as the go version. Reverting to the first approach of using go-version-input. Slack thread: https://redhat-internal.slack.com/archives/CHK0J6HT6/p1741939607080469?thread_ts=1741889746.719249&cid=CHK0J6HT6

Copy link

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, rsoaresd, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,rsoaresd,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsoaresd rsoaresd merged commit f3daa07 into codeready-toolchain:master Mar 14, 2025
11 of 14 checks passed
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.66%. Comparing base (5a1e5ca) to head (06e911c).
Report is 1 commits behind head on master.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
- Coverage   79.67%   79.66%   -0.02%     
==========================================
  Files          82       82              
  Lines        8245     8245              
==========================================
- Hits         6569     6568       -1     
- Misses       1480     1481       +1     
  Partials      196      196              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rsoaresd rsoaresd deleted the revert_go-version-file_usage branch March 14, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants