SANDBOX-808: update kube & openshift dependencies to 4.17

[rsoaresd]

Description

Update dependencies

Tool/Library	Current Version	Updates to Version
Golang	1.21	1.22
Operator SDK	1.36	1.38
k8s.io/*	v0.29.2	v0.30.1
controller-runtime	v0.17.3	v0.18.4

Note

Operator SDK will be updated in the next set of PRs along with toolchain-cicd and operators update

Issue ticket number and link

SANDBOX-808

Note

snyk reports a lot of vulnerabilities regarding go 1.22. From snyk's source, it seems all FPs. For more info, check this Slack thread

[ranakan19]

Looks good

[MatousJobanek]

Looks good 👍
I would love to use the generic functions to propagate the object type into the specific predicates & mappers. This can be done as a separate task though - in a separate PR, let's just create a story for it.

[MatousJobanek]

Btw, there are typed versions of the handlers and predicates, so you can use it:

source.Kind(memberCluster.Cache, &toolchainv1alpha1.SpaceBindingRequest{},
	&handler.TypedEnqueueRequestForObject[*toolchainv1alpha1.SpaceBindingRequest]{},
	predicate.TypedGenerationChangedPredicate[*toolchainv1alpha1.SpaceBindingRequest]{}))

but I'm not sure if it makes any sense in this particular case

[rsoaresd]

I think I tried that way when I saw that we needed to refactor the code. It gives this error:

type predicate.TypedGenerationChangedPredicate[*v1alpha1.SpaceBindingRequest] of predicate.TypedGenerationChangedPredicate[*toolchainv1alpha1.SpaceBindingRequest]{} does not match predicate.TypedPredicate[T] (cannot infer T)compilerCannotInferTypeArgs

[MatousJobanek]

probably not really related to this particular case since the mapper is generic, but there a function

handler.TypedEnqueueRequestsFromMapFunc

that takes the type provided in the source.Kind function and use it as the generics to provide the same type down to the mapper and predicate. This can be very useful in the mappers and predicates that are specific to resource kind like this one:

host-operator/controllers/usersignup/mapper.go

Lines 15 to 18 in 2d3af3b

	func MapBannedUserToUserSignup(cl runtimeclient.Client) func(ctx context.Context, object runtimeclient.Object) []reconcile.Request {
	var logger = ctrl.Log.WithName("BannedUserToUserSignupMapper")
	return func(ctx context.Context, obj runtimeclient.Object) []reconcile.Request {
	if bu, ok := obj.(*toolchainv1alpha1.BannedUser); ok {

or this one:

host-operator/controllers/spaceprovisionerconfig/mapper.go

Lines 28 to 33 in 2d3af3b

	func MapToolchainStatusToSpaceProvisionerConfigs(cl runtimeclient.Client) func(context.Context, runtimeclient.Object) []reconcile.Request {
	return func(ctx context.Context, obj runtimeclient.Object) []reconcile.Request {
	if _, ok := obj.(*toolchainv1alpha1.ToolchainStatus); !ok {
	return nil
	}

and there will be a few more

[rsoaresd]

Do you mean replacing EnqueueRequestsFromMapFunc with TypedEnqueueRequestsFromMapFunc on those calls and refactoring the code?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, ranakan19, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,fbm3307,ranakan19,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rsoaresd]

Looks good 👍 I would love to use the generic functions to propagate the object type into the specific predicates & mappers. This can be done as a separate task though - in a separate PR, let's just create a story for it.

@MatousJobanek thank you so much! https://issues.redhat.com/browse/SANDBOX-1022

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.7% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.68%. Comparing base (62dcb7b) to head (506102f).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
controllers/space/space_controller.go	0.00%	3 Missing ⚠️
...cebindingrequest/spacebindingrequest_controller.go	0.00%	3 Missing ⚠️
...ontrollers/spacerequest/spacerequest_controller.go	0.00%	3 Missing ⚠️
...rs/masteruserrecord/masteruserrecord_controller.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1146   +/-   ##
=======================================
  Coverage   79.68%   79.68%           
=======================================
  Files          82       82           
  Lines        8245     8245           
=======================================
  Hits         6570     6570           
  Misses       1479     1479           
  Partials      196      196           

Files with missing lines	Coverage Δ
test/spacebinding/spacebinding_assertions.go	88.23% <100.00%> (ø)
...rs/masteruserrecord/masteruserrecord_controller.go	80.64% <0.00%> (ø)
controllers/space/space_controller.go	85.98% <0.00%> (ø)
...cebindingrequest/spacebindingrequest_controller.go	84.47% <0.00%> (ø)
...ontrollers/spacerequest/spacerequest_controller.go	87.79% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.