-
Notifications
You must be signed in to change notification settings - Fork 27
SANDBOX-955: update kube & openshift dependencies to 4.18 #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SANDBOX-955: update kube & openshift dependencies to 4.18 #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
If I'm not mistaken, we should be already able to drop the fake GOPATH hack
Lines 42 to 53 in 708527c
@echo "re-generating the openapi go file..." | |
@## First, let's clean up anything that might have been left around... | |
@rm -Rf $(FAKE_GOPATH) | |
mkdir -p $(FAKE_GOPATH) | |
@mkdir -p $(CRT_IN_GOPATH) | |
@## link the packages from the local GOPATH to not have to download them again | |
@if [ -d $(LOCAL_GOPATH)/pkg ]; then cd $(FAKE_GOPATH) && ln -s $(LOCAL_GOPATH)/pkg; fi | |
@## link our codebase to the appropriate place in the fake GOPATH | |
@cd $(CRT_IN_GOPATH) && ln -s ../../../.. api | |
@## run openapi-gen from within the fake GOPATH (otherwise the package paths would be relative | |
@## and function names would be different) | |
GOPATH=$(FAKE_GOPATH) \ |
what was proposed in this PR #421 but we were not able to do it because of an old controller-runtime version (see comment)
It can be done as separate PR though ;-)
Thanks for bringing it up! Addressed 697fdae |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks.
Originally, I wanted to propose updating the operator-sdk version in the README file:
Operator SDK v1.38.0 - download for your development environment [here](https://v1-36-x.sdk.operatorframework.io/docs/installation/#install-from-github-release)
but I don't think that the operator-sdk is actually used in this repo, so the line can be removed.
Great catch, thanks! Addressed d71d6e8 |
|
Description
Update dependencies
Note
Operator SDK will be updated in the next set of PRs, along with toolchain-cicd and operators update
Issue ticket number and link
SANDBOX-955
Checks
Did you run
make generate
target? yesDid
make generate
change anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? N/A
resources/setup/roles/host.yaml
in the sandbox-sre repositoryPROJECT
file: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSV
file: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.