-
Notifications
You must be signed in to change notification settings - Fork 45
feat(envbuilder.go): add support for build secrets #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c9a1bf1
chore(envbuilder.go): prove the concept of build secret environment v…
SasSwart 56924ed
feat(devcontainer): add support for build-secrets
SasSwart 1416077
feat(devcontainer): add support for build-secrets
SasSwart 0b4ea02
fix(envbuilder.go): fix self review notes and linting
SasSwart 87e395a
Merge remote-tracking branch 'origin/main' into jjs/buildsecrets
SasSwart 9227192
fix(envbuilder.go): fix linting
SasSwart 7fff300
fix(envbuilder.go): add unit tests for build secret filtering
SasSwart c112f25
fix(integration): add integration tests for build secrets
SasSwart dbf7879
fix(integration): fix a test case for duplicate secret mounts
SasSwart 58ae81c
fix(integration): fix a test case for duplicate secret mounts
SasSwart f2e8acd
Merge remote-tracking branch 'origin/main' into jjs/buildsecrets
SasSwart e1a0a59
fix(options): further prevent flakes in options testing
SasSwart 1127121
Merge remote-tracking branch 'origin' into jjs/buildsecrets
SasSwart 3d9aac2
fix(envbuilder.go): properly declare an empty slice
SasSwart 39fe438
fix(envbuilder.go): document an exported function
SasSwart b0ee401
fix(options): add a note to some tests that cannot be run in parallel
SasSwart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.