feat: implement bufhidden=hide for native terminal toggle #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses #16 by implementing the core mechanism to preserve terminal processes when hiding windows. The native terminal provider now sets bufhidden=hide before closing windows, preventing Neovim from killing the terminal job when the window is closed. - Add hide_terminal() helper that sets bufhidden=hide before window close - Add show_hidden_terminal() to create windows for existing buffers - Add is_terminal_visible() for buffer visibility detection - Update toggle() logic to use hide/show instead of close/create - Add comprehensive test suite for toggle behavior verification - Optimize logger usage with module-level require This change enables process preservation during window hiding, laying the groundwork for full toggle behavior consistency with snacks provider. Change-Id: I334c00663dc2058eff2c362057e76499700b5e9e Signed-off-by: Thomas Kosiewski <tk@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the core mechanism to preserve terminal processes when hiding windows in the native terminal provider, partially addressing #16.
Key Changes:
bufhidden=hidesetting before window close to prevent job terminationTechnical Details
The native terminal provider now uses Neovim's
bufhidden=hideoption to preserve terminal jobs when windows are closed. This prevents the automatic cleanup that normally occurs when terminal windows are destroyed.Core Implementation:
hide_terminal(): Setsbufhidden=hidebefore closing windowshow_hidden_terminal(): Creates new window for existing bufferis_terminal_visible(): Detects if buffer is displayed in any windowTesting
Progress on #16
This PR implements the foundational mechanism for process preservation. A follow-up PR will complete the toggle behavior consistency by addressing the different toggling behaviors between providers.
Related: #16