fix: improve node codemod node modules resolution #1491
Merged
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
commit: |
mohebifar
deleted the
fix/improve-node-codemod-node-modules-resolution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to node modules resolution:
.changeset/gold-geckos-tap.md: Added a patch change for@codemod-com/runnerandcodemodto improve node modules resolution for the node codemod symlinking step.Codebase simplification:
packages/runner/src/runner.ts: Modified theRunnerclass to usemodule.paths.findfor locating thecli_node_modulesdirectory and added error handling for cases where the directory is not found.📚 Description
This pull request includes changes to improve the node modules resolution for the node codemod symlinking step and to handle cases where the
cli_node_modulesdirectory cannot be found. The most important changes include modifications to theRunnerclass inrunner.tsand an update to the changeset file.🔗 Linked Issue
🧪 Test Plan
📄 Documentation to Update