Skip to content

feat(runner): add child process support for specific codemod execution #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/ninety-candles-lie.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@codemod-com/runner": patch
"codemod": patch
---

fix: add child process support for specific codemod execution
9 changes: 5 additions & 4 deletions apps/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"yargs": "catalog:"
},
"scripts": {
"build": "tsc && node ./build.js",
"build": "tsc && node ./build.js -- --prod",
"build:local": "pnpm build -- --local",
"build:prod": "pnpm build -- --prod",
"build:publish": "pnpm build -- --publish",
Expand All @@ -91,10 +91,11 @@
"dependencies": {
"@ast-grep/cli": "catalog:",
"@ast-grep/napi": "catalog:",
"keytar": "catalog:",
"@codemod.com/workflow": "workspace:*",
"@nodejs-loaders/alias": "^1.1.1",
"@octokit/rest": "catalog:",
"blessed": "catalog:",
"@codemod.com/workflow": "workspace:*",
"esbuild": "^0.23.0"
"esbuild": "^0.23.0",
"keytar": "catalog:"
}
}
56 changes: 54 additions & 2 deletions packages/runner/src/runner.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { spawn } from "node:child_process";
import * as fs from "node:fs";
import { readFile } from "node:fs/promises";
import { dirname, join } from "node:path";
import { join as joinPosix } from "node:path/posix";
import { glob, globStream } from "glob";
import * as yaml from "js-yaml";

import type { Filemod } from "@codemod-com/filemod";
import { Printer, boxen, chalk, colorLongString } from "@codemod-com/printer";
Expand All @@ -21,12 +20,15 @@ import {
isRecipeCodemod,
} from "@codemod-com/utilities";
import type { AuthServiceInterface } from "@codemod.com/workflow";
import { glob, globStream } from "glob";
import * as yaml from "js-yaml";
import type { RunnerServiceInterface } from "#runner-service.js";
import {
getCodemodExecutable,
getRunConfig,
temporaryLoadedModules,
} from "#source-code.js";
import { getRandomMjs, shouldRunAsChildNodeProcess } from "#utils.js";
import { astGrepLanguageToPatterns } from "./engines/ast-grep.js";
import type { Dependencies } from "./engines/filemod.js";
import { runFilemod } from "./engines/filemod.js";
Expand Down Expand Up @@ -492,6 +494,56 @@ export class Runner {
return await onSuccess?.({ codemod, output: "", commands: [] });
}

if (shouldRunAsChildNodeProcess(codemod.config.name)) {
const randomMjs = join(process.cwd(), getRandomMjs());
await fs.promises.copyFile(
join(codemod.path, "cdmd_dist", "index.js"),
randomMjs,
);
const cliNodeModules = join(dirname(__dirname), "node_modules");
const symlinkedPackages: string[] = [];
const cliNodeModulesDir = await fs.promises.readdir(cliNodeModules);
const targetNodeModulesDir = join(process.cwd(), "node_modules");

for (const dir of cliNodeModulesDir) {
if (fs.existsSync(join(targetNodeModulesDir, dir)) || dir === ".bin") {
continue;
}

await fs.promises.symlink(
join(cliNodeModules, dir),
join(targetNodeModulesDir, dir),
);

symlinkedPackages.push(dir);
}

return new Promise<void>((resolve, reject) => {
const child = spawn(process.execPath, [randomMjs], {
stdio: "inherit",
cwd: process.cwd(),
});

child.on("close", async (code) => {
await fs.promises.unlink(randomMjs);
for (const dir of symlinkedPackages) {
await fs.promises.unlink(join(targetNodeModulesDir, dir));
}

if (code === 0) {
await onSuccess?.({ codemod, output: "", commands: [] });
resolve();
} else {
reject(new Error(`Process exited with code ${code}`));
}
});

child.on("error", (err) => {
reject(err);
});
});
}

const codemodSource = await getCodemodExecutable(
codemod.path,
flowSettings.esm,
Expand Down
8 changes: 8 additions & 0 deletions packages/runner/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,11 @@ export const isTheSameData = (oldData: string, newData: string) => {
return false;
}
};

export const getRandomMjs = () => {
return `${Math.random().toString(36).substring(2, 15)}_${Math.random().toString(36).substring(2, 15)}.mjs`;
};

export const shouldRunAsChildNodeProcess = (codemodName: string) => {
return codemodName === "correct-ts-specifiers";
};
Loading
Loading