This repository was archived by the owner on Nov 24, 2024. It is now read-only.
Fix code scanning alert no. 5: Use of a broken or risky cryptographic algorithm #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… algorithm Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/codehaus-plexus/plexus-cipher/security/code-scanning/5
To fix the problem, we should replace the use of
AES/CBC/PKCS5PaddingwithAES/GCM/NoPadding. GCM (Galois/Counter Mode) provides both encryption and integrity, making it a more secure choice. This change involves updating theCIPHER_ALGconstant and modifying thecreateCiphermethod to handle the GCM-specific parameters.CIPHER_ALGconstant to useAES/GCM/NoPadding.createCiphermethod to generate a GCM parameter spec with a nonce.Suggested fixes powered by Copilot Autofix. Review carefully before merging.