Skip to content

CR-14519-heartbeat #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
name: codefresh-report-image
version: 0.0.155
version: 0.0.156
7 changes: 3 additions & 4 deletions src/logger.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import winston from 'winston'
import chalk from 'chalk'

const format = winston.format
const paint = (kind, message) => {
const painter = {
error: chalk.red,
Expand All @@ -17,14 +16,14 @@ const paint = (kind, message) => {


export const logger = winston.createLogger({
format: format.printf((info) => {
format: winston.format.printf((info) => {
return paint(info.level, `${info.message}`)
}),
transports: [ new winston.transports.Console() ],
transports: [ new winston.transports.Console({ level: process.env.DEBUG === '1' ? 'debug' : 'info' }) ],
})

export const workflowLogger = winston.createLogger({
format: format.printf((info) => {
format: winston.format.printf((info) => {
let logMessage = `${info.message}`
if (info.pod) {
logMessage = `[${info.pod}] ${logMessage}`
Expand Down
38 changes: 34 additions & 4 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { logger, workflowLogger } from './logger'

const { EventSourceError } = errors

const INITIAL_HEARTBEAT_TIMEOUT_IN_SEC = Number(process.env.INITIAL_HEARTBEAT_TIMEOUT_IN_SECONDS) || 5

/**
* Take (CF_ prefixed) Env variables and perform http/s request (SSE) to app-proxy for image-report with CF_ENRICHERS
Expand All @@ -26,12 +27,21 @@ async function main(argv, env): Promise<void> {
logger.info(`CI provider: ${payload['CF_CI_TYPE']}, job URL: ${payload['CF_WORKFLOW_URL']}`)
}
const eventSource = new EventSource(url, { headers })
eventSource.reconnectInterval = 1000*10000 // prevent retry. client should not issue a reconnect
eventSource.reconnectInterval = 1000 * 100000 // prevent retry. client should not issue a reconnect

let heartbeatTimer: Utils.Timer

const waitFor = new Promise<void>((resolve, reject) => {

eventSource.addEventListener('report', function (event) {
logger.info(JSON.stringify(JSON.parse(event.data), null, 2))

eventSource.addEventListener('open', function () {
logger.debug('event-source connected')

heartbeatTimer = Utils.createHeartbeatTimer(() => {
logger.debug(`missing heartbeat after ${heartbeatTimer.timeoutTime / 1000} seconds`)
heartbeatTimer.restart()
}, INITIAL_HEARTBEAT_TIMEOUT_IN_SEC * 1000)
})

eventSource.addEventListener('info', function (event) {
logger.info(event.data)
})
Expand All @@ -46,7 +56,22 @@ async function main(argv, env): Promise<void> {
workflowLogger.info(event.data)
}
})
eventSource.addEventListener('heartbeat', function (event) {
logger.debug(`heartbeat ${JSON.stringify(event)}`)

const heartBeatInterval = Number(event.data)
if (heartBeatInterval) {
const extraGap = 1 * 1000
heartbeatTimer.restart(heartBeatInterval + extraGap)
} else {
heartbeatTimer.restart()
}
})
eventSource.addEventListener('error', (errorEvent) => {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (heartbeatTimer) {
heartbeatTimer.stop()
}
eventSource.close()

const error = Utils.tryParseJson(errorEvent.data)
Expand All @@ -67,7 +92,12 @@ async function main(argv, env): Promise<void> {
reject(new EventSourceError(message, name))
})
eventSource.addEventListener('end', (event) => {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (heartbeatTimer) {
heartbeatTimer.stop()
}
eventSource.close()

logger.info(event.data)
resolve()
})
Expand Down
21 changes: 21 additions & 0 deletions src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,26 @@ export namespace Utils {
return str
}
}

export type Timer = {
timeoutTime: number,
restart: (timeoutMs?: number) => void,
stop: () => void,
}

export function createHeartbeatTimer(cb: () => void, timeoutTime: number): Timer {
let timeout: NodeJS.Timeout = setTimeout(cb, timeoutTime)

return {
timeoutTime,
restart(_timeoutMs?: number) {
this.stop()
timeout = setTimeout(cb, _timeoutMs || this.timeoutTime)
},
stop() {
clearTimeout(timeout)
}
}
}
}