Skip to content

Added toggle open/close to link click and make drawer title stick to top #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JacobBaqleh1
Copy link
Contributor

@JacobBaqleh1 JacobBaqleh1 commented Jun 7, 2025

Summary

This pull request improves the StatuteDrawer component with the following features:

  • Sticky Header on Desktop and Mobile

  • Toggle Drawer When Policy is Clicked

Screenshot (Mobile View)

image

Video

2025-06-07.14-15-00.mp4

@JacobBaqleh1 JacobBaqleh1 reopened this Jun 7, 2025
@leekahung
Copy link
Contributor

Hm...the sticky on the desktop version looks nice, but I was wondering if we should have it sticky for mobile as well?

I'm not sure how often, but people might just want to click on the external link to see the full details.

@JacobBaqleh1
Copy link
Contributor Author

@leekahung good point. The reason I didn't add it on mobile was that there isn't that much room to read. But at the same time, being able to click the external link is important. Im okay with including the sticky header on mobile. Maybe I can increase the height of the pop up drawer

@JacobBaqleh1
Copy link
Contributor Author

@leekahung added the sticky header for mobile. I included a screen shot in the PR

@leekahung
Copy link
Contributor

Nitpick: the top padding of the drawer and the top padding for the content in the mobile version can be made smaller. But I'm fine with having this merged. 👍

@JacobBaqleh1
Copy link
Contributor Author

Nitpick: the top padding of the drawer and the top padding for the content in the mobile version can be made smaller. But I'm fine with having this merged. 👍

good point!

@JacobBaqleh1 JacobBaqleh1 merged commit 1b2e504 into codeforpdx:main Jun 13, 2025
2 checks passed
@JacobBaqleh1 JacobBaqleh1 deleted the jacobbaqleh/statue-drawer-edit branch June 13, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants