fix feedback email url #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
going to merge because i want to start a branch for #453 and also this is a bug we should fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the function to generate the feedback URL for meetings (when users see a "Update Meeting Info" button) is located in loadMeetingData, which is both wasteful and causes a bug:
it's wasteful because it runs for every meeting, whether the user even sees the button or not
it's buggy because the feedback email does not contain a link to the meeting even though it's supposed to:
before:
after:
this PR moves the logic to the Meeting component so it only runs when the user sees the button and the meeting slug is in the URL