Skip to content

Introduce Playwright plugin config #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2024
Merged

Introduce Playwright plugin config #31

merged 2 commits into from
Dec 31, 2024

Conversation

Tlacenka
Copy link
Collaborator

@Tlacenka Tlacenka commented Dec 31, 2024 •
edited
Loading

In this PR I introduce ESLint config for Playwright using their official plugin.

Notable changes

  • While the plugin is primarily aimed at E2E projects, I also included the regular spec|test pattern.
  • For now I created just one configuration. Modifications might be needed for projects heavily utilising POMs.
  • I reduced severity for conditionals based on similar approach in the jest config.

@Tlacenka Tlacenka requested a review from matejchalk December 31, 2024 14:28
@Tlacenka Tlacenka self-assigned this Dec 31, 2024
matejchalk
matejchalk reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution 🎉 🚀

@Tlacenka Tlacenka requested a review from matejchalk December 31, 2024 15:40
@Tlacenka Tlacenka merged commit ae322d6 into code-pushup:main Dec 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees

@Tlacenka Tlacenka

Labels
🧩 eslint-config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tlacenka @matejchalk