Skip to content

Improved the thumbnails per row adding more options to choose. #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

wbalbo
Copy link
Contributor

@wbalbo wbalbo commented May 14, 2025

This should solve the issues #2910, #2904, and #2905

Added a dropdown in the menu General, subsection Thumbnails, with 5 options to choose from
image

Should be updated in real time and saved for future interactions with YouTube.

Is also working on the Subscriptions page on grid mode, seems to not be perfect, though, I noticed some visual bugs, like when selecting 6 videos appearing 5, I had to refresh the page to fix but wasn't 100% on all rows, also could vary depending on the size of the your tab, so maybe need some more adjustments, but for the Home page seems fine.

Also, I tested on an Ultrawide Quad HD monitor (3440x1440), so for sure will work differently on smaller monitors/resolutions, let me know about it.

Tested on both Chrome and Edge.

@wbalbo wbalbo requested a review from ImprovedTube May 14, 2025 23:56
@wbalbo wbalbo self-assigned this May 14, 2025
@wbalbo
Copy link
Contributor Author

wbalbo commented May 15, 2025

Solved conflicts with the merge from #2889

@ImprovedTube ImprovedTube merged commit fb9d22e into code-charity:master May 15, 2025
1 check passed
@ImprovedTube
Copy link
Member

We can still add a default / reset / no change option. (for users' piece of mind.)


Not that it is linguistically streamlined currently:

Nor technically:

if (!language || language === 'default') { language = false; }
document.querySelector("html")?.setAttribute("it-player-size", ImprovedTube.storage.player_size ?? "do_not_change");

@wbalbo
Copy link
Contributor Author

wbalbo commented May 15, 2025

We can still add a default / reset / no change option. (for users' piece of mind.)

Not that it is linguistically streamlined currently:

Nor technically:

if (!language || language === 'default') { language = false; }

document.querySelector("html")?.setAttribute("it-player-size", ImprovedTube.storage.player_size ?? "do_not_change");

Yeah, originally I had a Default option, but for some reason I removed it haha.

Let me know when this will be released because it is a very useful change, in my opinion. I tested here and improved my experience with the homepage.

@wbalbo wbalbo deleted the feat-thumbnails-per-row branch May 15, 2025 18:13
@MisterTickle
Copy link

Is it this "changeThumbnailsP." option, which has its name very oddly chopped off?

image

@wbalbo
Copy link
Contributor Author

wbalbo commented May 22, 2025

Is it this "changeThumbnailsP." option, which has its name very oddly chopped off?

image

The feature is correct, but the name really is strange, haha.

@ImprovedTube, did you change something? I noticed that you changed the numbers in a previous commit.

@MisterTickle
Copy link

Is it this "changeThumbnailsP." option, which has its name very oddly chopped off?
image

The feature is correct, but the name really is strange, haha.

Oh! Because changing that doplist makes no change at all to the thumbnails either on the Home page (which I never, ever use)
or the Subscriptions page (which I use heavily). This is in version 4.1260. I asked the question because I wasn't sure if I had the version with the fix included.

I'm only interested in the fix for the Subscriptions page, were you able to tweak it any more to avoid the issues you saw?

@wbalbo
Copy link
Contributor Author

wbalbo commented May 22, 2025

Is it this "changeThumbnailsP." option, which has its name very oddly chopped off?
image

The feature is correct, but the name really is strange, haha.

Oh! Because changing that doplist makes no change at all to the thumbnails either on the Home page (which I never, ever use) or the Subscriptions page (which I use heavily). This is in version 4.1260. I asked the question because I wasn't sure if I had the version with the fix included.

I'm only interested in the fix for the Subscriptions page, were you able to tweak it any more to avoid the issues you saw?

I have the latest version of the code here, and it is fine on both the Home and Subscriptions pages, a sample with 8 thumbs from Subs, in Chrome:
image

Maybe your version is not updated? I guess it was sent to the stores, but they have not released the latest version yet, from last week.

One thing that I noticed is that whenever you switch from Home to Subs and vice-versa, YouTube forces the thumbs to go back to 4, and to fix you have to refresh the page. I am not sure if there is a fix for this, but I will try to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants