Skip to content

Commit a5e7fe4

Browse files
committed
confirm support for CockroachDB 24.1
1 parent ef465e1 commit a5e7fe4

File tree

4 files changed

+19
-1
lines changed

4 files changed

+19
-1
lines changed

.github/workflows/tests.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ jobs:
4444
use_psycopg2: psycopg2
4545
- crdb-version: v23.2.0
4646
use_server_side_binding: server_side_binding
47+
- crdb-version: v24.1.0
48+
- crdb-version: v24.1.0
49+
use_psycopg2: psycopg2
50+
- crdb-version: v24.1.0
51+
use_server_side_binding: server_side_binding
4752
# Uncomment to enable testing of CockroachDB nightly.
4853
#- crdb-version: LATEST
4954
#- crdb-version: LATEST

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
- Confirm support for CockroachDB 23.2.x (no code changes required), which adds
66
support for ordering by JSON.
77

8+
- Confirm support for CockroachDB 24.1.x (no code changes required).
9+
810
## 5.0 - 2023-12-11
911

1012
Initial release for Django 5.0.x and CockroachDB 22.2.x and 23.1.x.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ By default, CockroachDB sends the version of django-cockroachdb that you're
9292
using back to Cockroach Labs. To disable this, set
9393
`DISABLE_COCKROACHDB_TELEMETRY = True` in your Django settings.
9494

95-
## Known issues and limitations in CockroachDB 23.2.x and earlier
95+
## Known issues and limitations in CockroachDB 24.1.x and earlier
9696

9797
- CockroachDB [can't disable constraint checking](https://github.com/cockroachdb/cockroach/issues/19444),
9898
which means certain things in Django like forward references in fixtures

django_cockroachdb/features.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,10 @@ def introspected_field_types(self):
7979
def is_cockroachdb_23_2(self):
8080
return self.connection.cockroachdb_version >= (23, 2)
8181

82+
@cached_property
83+
def is_cockroachdb_24_1(self):
84+
return self.connection.cockroachdb_version >= (24, 1)
85+
8286
@cached_property
8387
def django_test_expected_failures(self):
8488
expected_failures = super().django_test_expected_failures
@@ -196,6 +200,13 @@ def django_test_expected_failures(self):
196200
# https://github.com/cockroachdb/cockroach/issues/73587#issuecomment-988408190
197201
'aggregation.tests.AggregateTestCase.test_aggregation_default_using_decimal_from_database',
198202
})
203+
if self.is_cockroachdb_24_1:
204+
# USING cast required: https://github.com/cockroachdb/cockroach/issues/82416#issuecomment-2029803229
205+
expected_failures.update({
206+
'schema.tests.SchemaTests.test_alter_text_field_to_date_field',
207+
'schema.tests.SchemaTests.test_alter_text_field_to_datetime_field',
208+
'schema.tests.SchemaTests.test_alter_text_field_to_time_field',
209+
})
199210
if self.uses_server_side_binding:
200211
expected_failures.update({
201212
# could not determine data type of placeholder:

0 commit comments

Comments
 (0)