confirm support for CockroachDB 23.2

Author: timgraham

.github/workflows/tests.yml

@@ -39,6 +39,11 @@ jobs:
             use_psycopg2: psycopg2
           - crdb-version: v23.1.11
             use_server_side_binding: server_side_binding
+          - crdb-version: v23.2.0
+          - crdb-version: v23.2.0
+            use_psycopg2: psycopg2
+          - crdb-version: v23.2.0
+            use_server_side_binding: server_side_binding
           # Uncomment to enable testing of CockroachDB nightly.
           #- crdb-version: LATEST
           #- crdb-version: LATEST

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 5.0.1 - Unreleased
+
+- Confirm support for CockroachDB 23.2.x (no code changes required), which adds
+  support for ordering by JSON.
+
 ## 5.0 - 2023-12-11
 
 Initial release for Django 5.0.x and CockroachDB 22.2.x and 23.1.x.

README.md

@@ -92,7 +92,7 @@ By default, CockroachDB sends the version of django-cockroachdb that you're
 using back to Cockroach Labs. To disable this, set
 `DISABLE_COCKROACHDB_TELEMETRY = True` in your Django settings.
 
-## Known issues and limitations in CockroachDB 23.1.x and earlier
+## Known issues and limitations in CockroachDB 23.2.x and earlier
 
 - CockroachDB [can't disable constraint checking](https://github.com/cockroachdb/cockroach/issues/19444),
   which means certain things in Django like forward references in fixtures
@@ -144,3 +144,7 @@ using back to Cockroach Labs. To disable this, set
      - [overlaps_left (&<), overlaps_right (&>), overlaps_above (&<|),
        overlaps_below (&>|)](https://github.com/cockroachdb/cockroach/issues/57098)
      - [strictly_above (|>>), strictly_below (<<|)](https://github.com/cockroachdb/cockroach/issues/57095)
+
+ ## Known issues and limitations in CockroachDB 23.1.x and earlier
+
+- CockroachDB doesn't support by ordering by JSON.

django_cockroachdb/features.py

@@ -75,6 +75,10 @@ def introspected_field_types(self):
         'virtual': None,
     }
 
+    @cached_property
+    def is_cockroachdb_23_2(self):
+        return self.connection.cockroachdb_version >= (23, 2)
+
     @cached_property
     def django_test_expected_failures(self):
         expected_failures = super().django_test_expected_failures
@@ -154,19 +158,6 @@ def django_test_expected_failures(self):
             'many_to_one.tests.ManyToOneTests.test_get_prefetch_querysets_reverse_invalid_querysets_length',
             'migrations.test_operations.OperationTests.test_smallfield_autofield_foreignfield_growth',
             'migrations.test_operations.OperationTests.test_smallfield_bigautofield_foreignfield_growth',
-            # unsupported comparison operator: <jsonb> > <string>:
-            # https://github.com/cockroachdb/cockroach/issues/49144
-            'model_fields.test_jsonfield.TestQuerying.test_deep_lookup_transform',
-            # ordering by JSON isn't supported:
-            # https://github.com/cockroachdb/cockroach/issues/35706
-            'expressions_window.tests.WindowFunctionTests.test_key_transform',
-            'model_fields.test_jsonfield.TestQuerying.test_deep_distinct',
-            'model_fields.test_jsonfield.TestQuerying.test_order_grouping_custom_decoder',
-            'model_fields.test_jsonfield.TestQuerying.test_ordering_by_transform',
-            'model_fields.test_jsonfield.TestQuerying.test_ordering_grouping_by_key_transform',
-            # cannot index a json element:
-            # https://github.com/cockroachdb/cockroach/issues/35706
-            'schema.tests.SchemaTests.test_func_index_json_key_transform',
             # unexpected unique index in pg_constraint query:
             # https://github.com/cockroachdb/cockroach/issues/61098
             'introspection.tests.IntrospectionTests.test_get_constraints_unique_indexes_orders',
@@ -182,13 +173,29 @@ def django_test_expected_failures(self):
             # <int> * <int> (desired <decimal>):
             # https://github.com/cockroachdb/cockroach/issues/73587
             'aggregation.tests.AggregateTestCase.test_aggregation_default_expression',
-            # DataError: incompatible COALESCE expressions: expected pi() to be
-            # of type decimal, found type float
-            # https://github.com/cockroachdb/cockroach/issues/73587#issuecomment-988408190
-            'aggregation.tests.AggregateTestCase.test_aggregation_default_using_decimal_from_database',
             # ProgrammingError: VALUES types int and float cannot be matched
             'field_defaults.tests.DefaultTests.test_bulk_create_mixed_db_defaults_function',
         })
+        if not self.is_cockroachdb_23_2:
+            expected_failures.update({
+                # cannot index a json element:
+                # https://github.com/cockroachdb/cockroach/issues/35706
+                'schema.tests.SchemaTests.test_func_index_json_key_transform',
+                # ordering by JSON isn't supported:
+                # https://github.com/cockroachdb/cockroach/issues/35706
+                'expressions_window.tests.WindowFunctionTests.test_key_transform',
+                'model_fields.test_jsonfield.TestQuerying.test_deep_distinct',
+                'model_fields.test_jsonfield.TestQuerying.test_order_grouping_custom_decoder',
+                'model_fields.test_jsonfield.TestQuerying.test_ordering_by_transform',
+                'model_fields.test_jsonfield.TestQuerying.test_ordering_grouping_by_key_transform',
+                # unsupported comparison operator: <jsonb> > <string>:
+                # https://github.com/cockroachdb/cockroach/issues/49144
+                'model_fields.test_jsonfield.TestQuerying.test_deep_lookup_transform',
+                # DataError: incompatible COALESCE expressions: expected pi() to be
+                # of type decimal, found type float
+                # https://github.com/cockroachdb/cockroach/issues/73587#issuecomment-988408190
+                'aggregation.tests.AggregateTestCase.test_aggregation_default_using_decimal_from_database',
+            })
         if self.uses_server_side_binding:
             expected_failures.update({
                 # could not determine data type of placeholder: