Skip to content

Replay changing config #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 25, 2024
Merged

Replay changing config #56

merged 3 commits into from
Dec 25, 2024

Conversation

wangpatrick57
Copy link
Member

@wangpatrick57 wangpatrick57 commented Dec 25, 2024 •
edited
Loading

Summary: Replay now applies config deltas.

Demo:
Modified test that passes.
Screenshot 2024-12-24 at 20 18 09

Details:

  • Undoing query knobs is not yet handled. This depends on whether the interface takes in config deltas or full configs for query knobs which depends on how the agents work.

@wangpatrick57 wangpatrick57 changed the title draft pr for ci: replay-config-deltas Replay changing config Dec 25, 2024
@wangpatrick57 wangpatrick57 merged commit 7a30af5 into cmu-db:main Dec 25, 2024
1 check passed
@wangpatrick57 wangpatrick57 deleted the replay-config-deltas branch December 25, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wangpatrick57