Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 2, 2025

PR description:

The goal of this PR is twofold.
Following the merge of PR #48921, part of the Phase 2 HLT menu (the chain from pixel digis to pixel tracks and vertices) now can run on GPU. As the HLT phase2 timing test is run on a "Milan" node equipped with NVIDIA T4s, this on one hand has improved the general timing of the menu, but on the other hand it doesn't give back a realistic picture of the time needed to run when no GPU backed is available, for example when running MC productions.
The first goal of this PR is ensure that part of the timing tests run on CPU.
At the same time, it is now possible to be more aggressive with the reconstruction used in the NGT menu to avoid running full tracking on all events accepted by the L1T, but profiting of the phase 2 CA extension implemented in #48921 use the pixel track collection as "general" track collection for the rest of the HLT reconstruction (analogously to what done in runTheMatrix.py for workflow family XXXXX.774).

PR validation:

None, will be tested in the PR itself

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

- Add test to run the Phase 2 HLT timing menu forcing CPU backend
- modify the NGT menu test to use ngtScouting and phase2CAExtension modifiers
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2025

type ngt

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a5d18/49171/summary.html
COMMIT: a17f97e
CMSSW: CMSSW_16_0_X_2025-11-02-0000/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49279/49171/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3939953
  • DQMHistoTests: Total failures: 45
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3939888
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2025

enable hlt_p2_timing

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2025

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a5d18/49175/summary.html
COMMIT: a17f97e
CMSSW: CMSSW_16_0_X_2025-11-02-0000/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49279/49175/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3939953
  • DQMHistoTests: Total failures: 45
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3939888
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Nov 3, 2025

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link

+1

@cmsbuild cmsbuild merged commit 0b053b6 into cms-sw:master Nov 3, 2025
11 of 12 checks passed
@mmusich mmusich deleted the mm_update_runHLTTiming_post-48921 branch November 3, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants