Skip to content

Conversation

rdenadai
Copy link
Contributor

@rdenadai rdenadai commented Oct 1, 2025

This is a new PR addressing comments from #2334 and should "fix" Issue #2333

Sorry for closing the old one and open a new ... but I wasn't able to fully do all operations on my work account, so I moved to my personal one.

@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 20:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the oracle-ee-cdb engine and modernizes the RDS engine validation by converting the valid engines list to a set and adding several new engine types. This update addresses issue #2333 by including the missing oracle-ee-cdb engine type.

  • Added oracle-ee-cdb engine to valid RDS engines
  • Converted VALID_DB_ENGINES from tuple to set for better performance
  • Added additional engine types including DB2 and CDB variants

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rdenadai rdenadai changed the title feat: Add new oracle-ee-cdb engine to the valid db engine on rds validator Add new oracle-ee-cdb engine to the valid db engine on rds validator Oct 1, 2025
@rdenadai rdenadai force-pushed the update-rds-validate-engines branch from 8be559a to b1f59d6 Compare October 1, 2025 23:44
@rdenadai
Copy link
Contributor Author

rdenadai commented Oct 1, 2025

troposphere [ update-rds-validate-engines][?][📦 v0.0.0][ v22.19.0][🐍 v3.11.11]
❯ uv run make fix lint test
warning: No requires-python value found in the workspace. Defaulting to >=3.11.
All done! ✨ 🍰 ✨
575 files left unchanged.
Running flake8...
7.3.0 (mccabe: 0.7.0, pycodestyle: 2.14.0, pyflakes: 3.4.0) CPython 3.11.11 on Linux

Running pyright...
/ssd/projetos/troposphere/troposphere/compat.py
/ssd/projetos/troposphere/troposphere/compat.py:2:10 - warning: Import "awacs.aws" could not be resolved (reportMissingImports)
/ssd/projetos/troposphere/troposphere/compat.py:11:14 - warning: Import "awacs.aws" could not be resolved (reportMissingImports)
/ssd/projetos/troposphere/troposphere/serverless.py
/ssd/projetos/troposphere/troposphere/serverless.py:45:10 - warning: Import "awacs.aws" could not be resolved (reportMissingImports)
/ssd/projetos/troposphere/troposphere/validators/ssm.py
/ssd/projetos/troposphere/troposphere/validators/ssm.py:25:16 - warning: Import "yaml" could not be resolved from source (reportMissingModuleSource)
0 errors, 4 warnings, 0 informations

======================================= test session starts ========================================
platform linux -- Python 3.11.11, pytest-8.4.2, pluggy-1.6.0
rootdir: /ssd/projetos/troposphere
configfile: pyproject.toml
plugins: cov-7.0.0, anyio-4.7.0
collected 561 items

tests/test_apigateway.py .. [ 0%]
tests/test_apigatewayv2.py ... [ 0%]
tests/test_appconfig.py ..... [ 1%]
tests/test_appsync.py .. [ 2%]
tests/test_asg.py ......... [ 3%]
tests/test_awslambda.py ........................ [ 8%]
tests/test_basic.py .......................................................... [ 18%]
tests/test_cloudformation.py ... [ 18%]
tests/test_cloudfront.py . [ 19%]
tests/test_cloudwatch.py ... [ 19%]
tests/test_codebuild.py .............. [ 22%]
tests/test_codecommit.py . [ 22%]
tests/test_config.py .. [ 22%]
tests/test_controltower.py .. [ 22%]
tests/test_dict.py ....... [ 24%]
tests/test_dlm.py ... [ 24%]
tests/test_ec2.py ...... [ 25%]
tests/test_ecr.py . [ 26%]
tests/test_ecs.py ............... [ 28%]
tests/test_efs.py ..... [ 29%]
tests/test_eks.py .... [ 30%]
tests/test_elasticloadbalancerv2.py ................ [ 33%]
tests/test_emr.py ... [ 33%]
tests/test_examples.py ..................................................................... [ 45%]
................. [ 49%]
tests/test_examples_template_generator.py .................................................. [ 57%]
.................................. [ 63%]
tests/test_findinmap.py .... [ 64%]
tests/test_fsx.py .. [ 65%]
tests/test_guardduty.py ... [ 65%]
tests/test_int_type.py . [ 65%]
tests/test_iottwinmaker.py .. [ 66%]
tests/test_language_extensions.py .. [ 66%]
tests/test_logs.py .... [ 67%]
tests/test_mappings.py .. [ 67%]
tests/test_networkfirewall.py .. [ 67%]
tests/test_opensearchservice.py . [ 68%]
tests/test_opsworks.py ..... [ 68%]
tests/test_parameters.py ..... [ 69%]
tests/test_policies.py ........... [ 71%]
tests/test_rds.py ................................ [ 77%]
tests/test_resiliencehub.py .... [ 78%]
tests/test_route53.py . [ 78%]
tests/test_s3.py ......... [ 80%]
tests/test_scheduler.py .. [ 80%]
tests/test_serverless.py ............................ [ 85%]
tests/test_sqs.py . [ 85%]
tests/test_ssm.py . [ 85%]
tests/test_stepfunctions.py ... [ 86%]
tests/test_tags.py ........ [ 87%]
tests/test_template.py ................. [ 90%]
tests/test_template_generator.py ....... [ 91%]
tests/test_userdata.py ..... [ 92%]
tests/test_validators.py ............................. [ 98%]
tests/test_wafv2.py ......... [ 99%]
tests/test_yaml.py .. [100%]

======================================= 561 passed in 1.32s ========================================

@rdenadai rdenadai requested a review from markpeek October 1, 2025 23:45
Copy link
Member

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@markpeek markpeek merged commit 1a5c9c2 into cloudtools:main Oct 2, 2025
6 checks passed
@markpeek
Copy link
Member

markpeek commented Oct 2, 2025

Excellent. Thank you for the PR and additional cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants