Skip to content

feat(aws_docdb_cluster): upgrade the default engine_version to 5.0.0 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gmeligio
Copy link
Contributor

@gmeligio gmeligio commented May 12, 2024

what

Upgrade the default engine_version to the latest as of today, which is 5.0.0.

why

  • To get the new features available and also the compatibility with MongoDB 5.0 API.
  • To avoid the problems that come with edge cases when upgrading from 3.6/4.0 to 5.0, if we wanted 5.0 since the beginning but forgot to specify it.

references

@RoseSecurity
Copy link
Contributor

/terratest

@RoseSecurity
Copy link
Contributor

Thank you for identifying this improvement and contributing! A few additions may be required for this change:

  • Updating the cluster_family to maintain parity with the version increase
  • Amazon DocumentDB 4.0/5.0 does not support r4.* instance_classes so that parameter will need to be updated to r5 as well

@Nuru
Copy link

Nuru commented Jun 20, 2024

I am opposed to updating the default, as that is a potentially breaking change, and as long as the default value is still supported, I think the disruption is not worth the benefit.

@gmeligio
Copy link
Contributor Author

Thank you for identifying this improvement and contributing! A few additions may be required for this change:

  • Updating the cluster_family to maintain parity with the version increase
  • Amazon DocumentDB 4.0/5.0 does not support r4.* instance_classes so that parameter will need to be updated to r5 as well

In that case, db.t4g.medium would be a cost-effective default supported in DocumentDB 4.0/5.0.

I am opposed to updating the default, as that is a potentially breaking change, and as long as the default value is still supported, I think the disruption is not worth the benefit.

OK. The idea was a nice to have, but it's not essential. Seeing that it's a breaking change, I'll close the PR.

@gmeligio gmeligio closed this Jun 20, 2024
@gmeligio gmeligio deleted the engine_version_5.0.0 branch June 20, 2024 13:15
@mergify mergify bot removed the triage Needs triage label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants